fix(2FA): use serializable transaction for failed attempts recording

This commit is contained in:
Rudy B. committed 2026-04-25 17:28:29 +02:00
1 parent df913fd77f
commit 5c5d1c3524
4 files changed
+38 -13

No files matched your search

+2 -1
View File
@@ -88,10 +88,11 @@ export async function POST(request: Request) {
// Verify TOTP
const secret = decryptSecret(twoFactor.secret);
if (!(await verifyTotp(token, secret))) {
await recordFailedAttempt(userId);
const { lockedUntil } = await recordFailedAttempt(userId);
return badRequest({
code: 'two-factor-error-invalid-code',
message: 'Invalid verification code',
...(lockedUntil && { lockedUntil }),
});
}
+2 -1
View File
@@ -48,10 +48,11 @@ export async function POST(request: Request) {
// Verify TOTP
const secret = decryptSecret(twoFactor.secret);
if (!(await verifyTotp(token, secret))) {
await recordFailedAttempt(userId);
const { lockedUntil } = await recordFailedAttempt(userId);
return badRequest({
code: 'two-factor-error-invalid-code',
message: 'Invalid verification code',
...(lockedUntil && { lockedUntil }),
});
}
+4 -2
View File
@@ -73,10 +73,11 @@ export async function POST(request: Request) {
const matchIndex = await verifyBackupCode(body.backupCode, hashes);
if (matchIndex === null) {
await recordFailedAttempt(userId);
const { lockedUntil } = await recordFailedAttempt(userId);
return badRequest({
code: 'two-factor-error-invalid-backup-code',
message: 'Invalid backup code',
...(lockedUntil && { lockedUntil }),
});
}
@@ -95,10 +96,11 @@ export async function POST(request: Request) {
const decryptedSecret = decryptSecret(twoFactor.secret);
if (!(await verifyTotp(token, decryptedSecret))) {
await recordFailedAttempt(userId);
const { lockedUntil } = await recordFailedAttempt(userId);
return badRequest({
code: 'two-factor-error-invalid-code',
message: 'Invalid verification code',
...(lockedUntil && { lockedUntil }),
});
}
+30 -9
View File
@@ -1,7 +1,9 @@
import { Prisma } from '@/generated/prisma/client';
import prisma from '@/lib/prisma';
const MAX_ATTEMPTS = 5;
const LOCKOUT_MINUTES = 15;
const MAX_RETRIES = 3;
export async function checkRateLimit(
userId: string,
@@ -14,16 +16,35 @@ export async function checkRateLimit(
return { allowed: true };
}
export async function recordFailedAttempt(userId: string): Promise<void> {
const record = await prisma.client.twoFactorRateLimit.upsert({
where: { userId },
update: { attempts: { increment: 1 }, updatedAt: new Date() },
create: { userId, attempts: 1, updatedAt: new Date() },
});
if (record.attempts >= MAX_ATTEMPTS) {
const lockedUntil = new Date(Date.now() + LOCKOUT_MINUTES * 60 * 1000);
await prisma.client.twoFactorRateLimit.update({ where: { userId }, data: { lockedUntil } });
export async function recordFailedAttempt(userId: string) {
let retries = 0;
while (retries < MAX_RETRIES) {
try {
return await prisma.transaction(
async (tx: Prisma.TransactionClient) => {
const record = await tx.twoFactorRateLimit.upsert({
where: { userId },
update: { attempts: { increment: 1 } },
create: { userId, attempts: 1 },
});
if (record.attempts >= MAX_ATTEMPTS) {
const lockedUntil = new Date(Date.now() + LOCKOUT_MINUTES * 60 * 1000);
await tx.twoFactorRateLimit.update({ where: { userId }, data: { lockedUntil } });
return { lockedUntil };
}
return {};
},
{ isolationLevel: Prisma.TransactionIsolationLevel.Serializable },
);
} catch (err: any) {
if (err.code === 'P2034') {
retries++;
continue;
}
throw err;
}
}
throw new Error('recordFailedAttempt: max retries exceeded');
}
export async function resetRateLimit(userId: string): Promise<void> {