Files
umami/src/lib/auth.ts
T
Mike Cao 8bc49a29e3 Fix share token confusion vulnerability
Cache tokens from /api/send and share tokens were both signed with the same secret and parsed without distinguishing claim types, allowing a public cache token to be replayed as x-umami-share-token to read any website's analytics. Add explicit token type claims (share/cache) and require the matching type when parsing each.
2026-06-02 14:45:21 -07:00

103 lines
2.5 KiB
TypeScript

import debug from 'debug';
import {
ROLE_PERMISSIONS,
ROLES,
SHARE_CONTEXT_HEADER,
SHARE_TOKEN_HEADER,
SHARE_TOKEN_TYPE,
} from '@/lib/constants';
import { createAuthKey, secret } from '@/lib/crypto';
import { createSecureToken, parseSecureToken, parseToken } from '@/lib/jwt';
import redis from '@/lib/redis';
import { ensureArray } from '@/lib/utils';
import { getUser } from '@/queries/prisma/user';
const log = debug('umami:auth');
export function getBearerToken(request: Request) {
const auth = request.headers.get('authorization');
return auth?.split(' ')[1];
}
export async function checkAuth(request: Request) {
const token = getBearerToken(request);
const payload = parseSecureToken(token, secret());
const shareToken = await parseShareToken(request);
let user = null;
const { userId, authKey } = payload || {};
if (userId) {
user = await getUser(userId);
} else if (redis.enabled && authKey) {
const key = await redis.client.get(authKey);
if (key?.userId) {
user = await getUser(key.userId);
}
}
log({ token, payload, authKey, shareToken, user });
if (!user?.id && !shareToken) {
log('User not authorized');
return null;
}
if (!user?.id && shareToken) {
const shareContext = request.headers.get(SHARE_CONTEXT_HEADER);
if (!shareContext) {
log('Share token used outside share context');
return null;
}
}
if (user) {
user.isAdmin = user.role === ROLES.admin;
}
return {
token,
authKey,
shareToken,
user,
};
}
export async function saveAuth(data: any, expire = 0) {
const authKey = `auth:${createAuthKey()}`;
if (redis.enabled) {
await redis.client.set(authKey, data);
if (expire) {
await redis.client.expire(authKey, expire);
}
}
return createSecureToken({ authKey }, secret());
}
export async function hasPermission(role: string, permission: string | string[]) {
return ensureArray(permission).some(e => ROLE_PERMISSIONS[role]?.includes(e));
}
export function parseShareToken(request: Request) {
try {
const token: any = parseToken(request.headers.get(SHARE_TOKEN_HEADER), secret());
// Only accept tokens explicitly minted as share tokens. This prevents other
// tokens signed with the same secret (e.g. the cache token from /api/send)
// from being replayed as share tokens to gain analytics access.
if (token?.type !== SHARE_TOKEN_TYPE) {
return null;
}
return token;
} catch (e) {
log(e);
return null;
}
}