Commit Graph
3 Commits
Author SHA1 Message Date
brantsrasmus 3c467e54d5 address review feedback
- SessionModal: merge caller-provided className with styles.modal instead
  of letting it be clobbered by the {...props} spread (matches ReplayModal).
- e2e test: narrow boundingBox()/viewport nullability without non-null
  assertions (keeps biome's noNonNullAssertion happy) via a getSheetBox
  helper and a shared VIEWPORT constant.
2026-07-03 11:56:13 +02:00
brantsrasmus 8dcd2c6190 fix: dismiss session modals when clicking the side margins
SessionModal and SessionProfileModal set their 1320px max width on an
inner Column rather than on the Modal itself. The react-zen Modal box
(placement="bottom") therefore stretched to the full viewport width
(inset-x-0), so its transparent left/right margins sat on top of the
underlay and swallowed outside-clicks. Only the thin offset strip above
the sheet was dismissable.

Move the width onto the Modal box via a CSS module — matching the
existing pattern in ReplayModal — so the click-catcher is the centered
~1320px sheet and the side margins become real overlay again.

Adds an e2e regression test covering left/right margin dismissal with an
in-sheet control click.
2026-07-03 11:47:20 +02:00
Mike Cao 216cf6c448 Migrate test suite from Cypress and Jest to Playwright and Vitest 2026-05-09 01:23:20 -07:00