From 816b51096df27bdcb806bd3bf82028e9ab474a58 Mon Sep 17 00:00:00 2001 From: seojcarlos Date: Wed, 8 Apr 2026 08:22:16 +0200 Subject: [PATCH] fix: guard toISOString calls against Invalid Date in Firefox The previous fix guarded startAt/endAt numeric values but left startDate/endDate calling .toISOString() on the potentially invalid result of localToUtc(), which throws TypeError in Firefox when zonedTimeToUtc returns Invalid Date. Now falls back to raw date .toISOString() when the UTC conversion is invalid. --- src/components/hooks/useDateParameters.ts | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/components/hooks/useDateParameters.ts b/src/components/hooks/useDateParameters.ts index 6600ce8bc..e174d8d54 100644 --- a/src/components/hooks/useDateParameters.ts +++ b/src/components/hooks/useDateParameters.ts @@ -7,14 +7,18 @@ export function useDateParameters() { } = useDateRange(); const { timezone, localToUtc, canonicalizeTimezone } = useTimezone(); - const startAtValue = +localToUtc(startDate); - const endAtValue = +localToUtc(endDate); + const utcStart = localToUtc(startDate); + const utcEnd = localToUtc(endDate); + const startAtValue = +utcStart; + const endAtValue = +utcEnd; + const isStartValid = Number.isFinite(startAtValue); + const isEndValid = Number.isFinite(endAtValue); return { - startAt: Number.isFinite(startAtValue) ? startAtValue : +startDate, - endAt: Number.isFinite(endAtValue) ? endAtValue : +endDate, - startDate: localToUtc(startDate).toISOString(), - endDate: localToUtc(endDate).toISOString(), + startAt: isStartValid ? startAtValue : +startDate, + endAt: isEndValid ? endAtValue : +endDate, + startDate: isStartValid ? utcStart.toISOString() : startDate.toISOString(), + endDate: isEndValid ? utcEnd.toISOString() : endDate.toISOString(), unit, timezone: canonicalizeTimezone(timezone), };