From 0b31d3a274f63d4a16279fe2566bb57d57e942bc Mon Sep 17 00:00:00 2001 From: Mike Cao Date: Fri, 24 Jul 2026 14:36:54 -0700 Subject: [PATCH] Mark Hebrew locale as RTL --- src/lib/lang.test.ts | 9 +-------- src/lib/lang.ts | 2 +- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/lib/lang.test.ts b/src/lib/lang.test.ts index e4c01a7a4..e60fa6dc4 100644 --- a/src/lib/lang.test.ts +++ b/src/lib/lang.test.ts @@ -20,17 +20,10 @@ describe('getTextDirection', () => { test('returns rtl for right-to-left languages', () => { expect(getTextDirection('ar-SA')).toBe('rtl'); expect(getTextDirection('fa-IR')).toBe('rtl'); + expect(getTextDirection('he-IL')).toBe('rtl'); expect(getTextDirection('ur-PK')).toBe('rtl'); }); - // NOTE: Hebrew (he-IL) is a right-to-left language but is NOT marked with - // `dir: 'rtl'` in `languages`, so getTextDirection returns 'ltr'. This asserts - // the current (suspected buggy) behavior. If the source is fixed to add - // `dir: 'rtl'` for he-IL, update this expectation to 'rtl'. - test('does not mark Hebrew as rtl (suspected source bug)', () => { - expect(getTextDirection('he-IL')).toBe('ltr'); - }); - test('returns ltr for left-to-right languages', () => { expect(getTextDirection('en-US')).toBe('ltr'); expect(getTextDirection('fr-FR')).toBe('ltr'); diff --git a/src/lib/lang.ts b/src/lib/lang.ts index f874640c4..20737a334 100644 --- a/src/lib/lang.ts +++ b/src/lib/lang.ts @@ -67,7 +67,7 @@ export const languages = { 'fo-FO': { label: 'Føroyskt' }, 'fr-FR': { label: 'Français', dateLocale: fr }, 'ga-ES': { label: 'Galacian (Spain)', dateLocale: es }, - 'he-IL': { label: 'עברית', dateLocale: he }, + 'he-IL': { label: 'עברית', dateLocale: he, dir: 'rtl' }, 'hi-IN': { label: 'हिन्दी', dateLocale: hi }, 'hr-HR': { label: 'Hrvatski', dateLocale: hr }, 'hu-HU': { label: 'Hungarian', dateLocale: hu },