From 0651168823bffb07ea50963aff269b23f52cd70f Mon Sep 17 00:00:00 2001 From: Francis Cao Date: Sat, 21 Feb 2026 23:05:16 -0800 Subject: [PATCH] fix bug when removed filter do not update --- src/components/input/FilterEditForm.tsx | 8 +------- src/components/input/WebsiteFilterButton.tsx | 5 ++++- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/components/input/FilterEditForm.tsx b/src/components/input/FilterEditForm.tsx index fd0f8d48d..f9458f99e 100644 --- a/src/components/input/FilterEditForm.tsx +++ b/src/components/input/FilterEditForm.tsx @@ -102,13 +102,7 @@ export function FilterEditForm({ websiteId, onChange, onClose }: FilterEditFormP - diff --git a/src/components/input/WebsiteFilterButton.tsx b/src/components/input/WebsiteFilterButton.tsx index e2484727a..1f04e2929 100644 --- a/src/components/input/WebsiteFilterButton.tsx +++ b/src/components/input/WebsiteFilterButton.tsx @@ -1,6 +1,6 @@ import { Checkbox, Row } from '@umami/react-zen'; import { useState } from 'react'; -import { useMessages, useNavigation } from '@/components/hooks'; +import { useFilters, useMessages, useNavigation } from '@/components/hooks'; import { ListFilter } from '@/components/icons'; import { DialogButton } from '@/components/input/DialogButton'; import { FilterEditForm } from '@/components/input/FilterEditForm'; @@ -15,14 +15,17 @@ export function WebsiteFilterButton({ }) { const { t, labels } = useMessages(); const { updateParams, pathname, router, query } = useNavigation(); + const { filters: currentFilters } = useFilters(); const [excludeBounce, setExcludeBounce] = useState(!!query.excludeBounce); const isOverview = /^\/teams\/[^/]+\/websites\/[^/]+$/.test(pathname) || /^\/share\/[^/]+$/.test(pathname); const handleChange = ({ filters, segment, cohort, match }: any) => { const params = filtersArrayToObject(filters); + const cleared = Object.fromEntries(currentFilters.map(f => [f.name, undefined])); const url = updateParams({ + ...cleared, ...params, segment, cohort,