From fcd3258a2c1e690fadfe7cbf78092e80475e7f54 Mon Sep 17 00:00:00 2001 From: S4NKALP Date: Fri, 10 Apr 2026 01:18:20 +0545 Subject: [PATCH] refactor(utils): simplify unknown handling in format_window MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Removed redundant checks for "unknown" in title and wmclass - Streamlined cleanup to treat "unknown" as empty strings - Always call format_app_name with update=True to sync service state - Improves readability and reduces edge‑case bugs --- utils/app_name_resolver.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/utils/app_name_resolver.py b/utils/app_name_resolver.py index a15b5cc..6757cc3 100644 --- a/utils/app_name_resolver.py +++ b/utils/app_name_resolver.py @@ -79,15 +79,11 @@ app_name_resolver = AppName() def format_window(title, wmclass): - # Handle the case when HyprlandActiveWindow passes "unknown" instead of empty strings - if (not title or title == "unknown") and (not wmclass or wmclass == "unknown"): - return "Finder" - - # Clean up "unknown" values + # Clean up "unknown" values to ensure they are treated as empty if title == "unknown": title = "" if wmclass == "unknown": wmclass = "" - name = app_name_resolver.format_app_name(title, wmclass, True) - return name + # Always call format_app_name with update=True to keep service state in sync + return app_name_resolver.format_app_name(title, wmclass, True)