refactor(modules): Clean up imports and centralize utilities- Enhancements:

- Remove redundant gi.repository imports
  - Move common utilities (GLib, GObject, logger, os) into fabric.utils
  - Centralize GLib usage and reduce namespace pollution
This commit is contained in:
sankalp committed 2026-04-10 00:10:40 +05:45
1 parent 9847bdf884
commit adb87456c7
12 files changed
+25 -41

No files matched your search

+9 -8
View File
@@ -1,6 +1,5 @@
# Standard library imports
import gc
import os
import re
import tempfile
import threading
@@ -9,7 +8,15 @@ import urllib.request
import weakref
from typing import Dict, List, Optional
from fabric.utils import bulk_connect, cooldown, invoke_repeater
from fabric.utils import (
bulk_connect,
cooldown,
invoke_repeater,
GLib,
GObject,
logger,
os,
)
from fabric.widgets.box import Box
from fabric.widgets.button import Button
from fabric.widgets.image import Image
@@ -20,8 +27,6 @@ from fabric.widgets.overlay import Overlay
from fabric.widgets.scale import Scale
from fabric.widgets.stack import Stack
from fabric.widgets.wayland import WaylandWindow as Window
from gi.repository import GLib, GObject
from loguru import logger
import config.data as data
@@ -908,8 +913,6 @@ class PlayerBox(Box):
# Cancel seek bar timer
if self._seekbar_timer_id:
try:
from gi.repository import GLib
GLib.source_remove(self._seekbar_timer_id)
except Exception:
pass
@@ -1038,8 +1041,6 @@ class PlayerBox(Box):
# Restart timer to ensure it's running with updated metadata
if self._seekbar_timer_id:
try:
from gi.repository import GLib
GLib.source_remove(self._seekbar_timer_id)
except Exception:
pass
+2 -7
View File
@@ -1,12 +1,7 @@
import os
import re
import time
from typing import List
from fabric.utils import (
bulk_connect,
)
from fabric.utils.helpers import get_relative_path
from fabric.widgets.box import Box
from fabric.widgets.button import Button
from fabric.widgets.centerbox import CenterBox
@@ -14,8 +9,8 @@ from fabric.widgets.image import Image
from fabric.widgets.label import Label
from fabric.widgets.overlay import Overlay
from fabric.widgets.stack import Stack
from gi.repository import Gio, GLib, GObject
from loguru import logger
from fabric.utils import GLib, GObject, Gio, logger, bulk_connect, get_relative_path, os
import config.data as data
from services.mpris import MprisPlayer, MprisPlayerManager
+1 -3
View File
@@ -14,6 +14,7 @@ from services.network import NetworkClient
from utils.functions import get_wifi_connecting_icon, get_wifi_icon_for_strength
from utils.utils import svg_file
from widgets.wifi_password_dialog import WiFiPasswordDialog
from gi.repository import NM
class WifiNetworkSlot(Box):
@@ -202,7 +203,6 @@ class WifiNetworkSlot(Box):
if success:
self.is_connected = True
# Remove connecting state after a short delay
from gi.repository import GLib
GLib.timeout_add(500, lambda: self._reset_connect_state())
@@ -544,8 +544,6 @@ class WifiConnections(Box):
# Compare SSIDs
connection_ssid_bytes = wifi_setting.get_ssid()
if connection_ssid_bytes:
from gi.repository import NM
connection_ssid = NM.utils_ssid_to_utf8(
connection_ssid_bytes.get_data()
)